Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slope Clock ++ #2216

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Slope Clock ++ #2216

merged 1 commit into from
Nov 4, 2022

Conversation

myxor
Copy link
Contributor

@myxor myxor commented Nov 2, 2022

I really like the new Slope Clock but i was missing some data - so i cloned it.

So we can have a minimal (maybe soon default?) Slope Clock and one with some extended features.

I hope this is okay.

screenshot

@gfwilliams
Copy link
Member

Thanks! This seems to be quite common now though - I'm wondering whether there isn't something we can do to reduce all the code duplication (like all the weather icons/etc and even duplication of clock code).

I've just started an issue at #2226 and I'd be really interested to hear your thoughts. clock_info is really cool and it'd be nice to make it super-easy for clocks to implement it

@gfwilliams gfwilliams merged commit e03c8c8 into espruino:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants