Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hadash: initial release #3558

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

hadash: initial release #3558

wants to merge 3 commits into from

Conversation

flaparoo
Copy link
Contributor

@flaparoo flaparoo commented Sep 5, 2024

This new app provides a powerful integration with Home-Assistant.
It allows both retrieving data as well as calling services in a fully configurable menu structure - in other words, almost full control of HA from your wrist!
(I didn't find this level of functionality in existing Bangle.js apps.)

@thyttan
Copy link
Collaborator

thyttan commented Sep 7, 2024

@bobrippling do you have HA stuff at home? I don't 🙃

@atjn
Copy link
Contributor

atjn commented Sep 8, 2024

I can test this one, but I can't say exactly when I have time for it.

@bobrippling
Copy link
Collaborator

bobrippling commented Sep 10, 2024

Works a treat with my HA setup, I can trigger services such as lights and scenes, and query entity states very well.

I have a few thoughts about improving the app, like returning to the same point in the menu and not requiring the user to tap ok after they've triggered a service, but I don't think they're part of this PR :)

Have two comments, happy to merge once they're resolved, or I can let you check it out too still @atjn

apps/hadash/jsoneditor.bundlejs Outdated Show resolved Hide resolved
apps/hadash/hadash.app.js Outdated Show resolved Hide resolved
@bobrippling
Copy link
Collaborator

Found an issue - when I trigger a service (for example), returning to the menu no longer displays the back button, leaving me stuck at that menu. The code looks ok so I suspect it may be a problem with the menu I'm using.

Will investigate when I have some more time in the next few days

@flaparoo
Copy link
Contributor Author

I have a few thoughts about improving the app, like returning to the same point in the menu and not requiring the user to tap ok after they've triggered a service, but I don't think they're part of this PR :)

I've added your suggestions as To-Dos in the README.

@atjn
Copy link
Contributor

atjn commented Sep 11, 2024

@bobrippling I think you should just release it, I plan on trying it out sometime in the next few weeks, and if I find anything I will create an issue/PR for it then :)

@bobrippling
Copy link
Collaborator

bobrippling commented Sep 12, 2024

Sounds good, let me know what you think of the code suggestion @flaparoo

@flaparoo
Copy link
Contributor Author

Your suggestion works well @bobrippling
I need to remember that trick.

So long "eval" - nobody seems to like you...

@flaparoo
Copy link
Contributor Author

I have a few thoughts about improving the app, like returning to the same point in the menu and not requiring the user to tap ok after they've triggered a service, but I don't think they're part of this PR :)

BTW you got me intrigued - there's already a PR in the works for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants