Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for php 8.4: explicit nullables #15

Merged
merged 1 commit into from
Feb 1, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/buildcheck.yml
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@ jobs:
- "8.1"
- "8.2"
- "8.3"
- "8.4"
composer:
- ""
- "--prefer-lowest"
6 changes: 3 additions & 3 deletions src/Parser.php
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@ final class Parser implements ParserInterface
*
* @param FactoryInterface $factory A segment factory for creating segments
*/
public function __construct(FactoryInterface $factory = null, TokenizerInterface $tokenizer = null)
public function __construct(?FactoryInterface $factory = null, ?TokenizerInterface $tokenizer = null)
{
if ($factory === null) {
$factory = new Factory();
@@ -59,7 +59,7 @@ public function __construct(FactoryInterface $factory = null, TokenizerInterface
* @return SegmentInterface[]
* @throws ParseException
*/
public function parse(string $message, ControlCharactersInterface $characters = null): iterable
public function parse(string $message, ?ControlCharactersInterface $characters = null): iterable
{
$characters = $this->getControlCharacters($message, $characters);

@@ -79,7 +79,7 @@ public function parse(string $message, ControlCharactersInterface $characters =
*
* @return ControlCharactersInterface
*/
private function getControlCharacters(string &$message, ControlCharactersInterface $characters = null): ControlCharactersInterface
private function getControlCharacters(string &$message, ?ControlCharactersInterface $characters = null): ControlCharactersInterface
{
if ($characters === null) {
$characters = new ControlCharacters();
2 changes: 1 addition & 1 deletion src/ParserInterface.php
Original file line number Diff line number Diff line change
@@ -17,5 +17,5 @@ interface ParserInterface
* @return iterable<SegmentInterface>
* @throws ParseException
*/
public function parse(string $message, ControlCharactersInterface $characters = null): iterable;
public function parse(string $message, ?ControlCharactersInterface $characters = null): iterable;
}
2 changes: 1 addition & 1 deletion src/Serializer.php
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ final class Serializer implements SerializerInterface
/**
* @param ControlCharactersInterface|null $characters
*/
public function __construct(ControlCharactersInterface $characters = null)
public function __construct(?ControlCharactersInterface $characters = null)
{
if ($characters === null) {
$characters = new ControlCharacters();
2 changes: 1 addition & 1 deletion tests/ParserTest.php
Original file line number Diff line number Diff line change
@@ -29,7 +29,7 @@ public function setUp(): void
}


public function getControlCharacters(string &$message, ControlCharactersInterface $characters = null): void
public function getControlCharacters(string &$message, ?ControlCharactersInterface $characters = null): void
{
if ($characters === null) {
$characters = Mockery::mock(ControlCharactersInterface::class);