Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lint, test and test-e2e GitHub workflows #58

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Jan 27, 2025

These workflows have already been migrated to Prow jobs.

Part of #21.

These workflows have already been migrated to Prow jobs.

Signed-off-by: Ivan Valdes <[email protected]>
@ivanvc ivanvc force-pushed the remove-github-workflows branch from 91a79cf to c9f54ef Compare January 27, 2025 22:41
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the help migrating these workflows @ivanvc 👍🏻

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit c1211f8 into etcd-io:main Jan 28, 2025
6 checks passed
@ahrtr
Copy link
Member

ahrtr commented Jan 28, 2025

@ivanvc after merging this PR, it seems the main branch only runs post-etcd-operator-lint when we merge each PR. I think we should also run all workflow checks on main when merging a PR.

@ivanvc
Copy link
Member Author

ivanvc commented Jan 29, 2025

@ivanvc after merging this PR, it seems the main branch only runs post-etcd-operator-lint when we merge each PR. I think we should also run all workflow checks on main when merging a PR.

Sorry, I followed the same approach we have in the etcd repo.

@ivanvc ivanvc deleted the remove-github-workflows branch January 29, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants