Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the initial scaffold of certificate management #59

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Add the initial scaffold of certificate management #59

merged 1 commit into from
Jan 30, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 28, 2025

@ahrtr
Copy link
Member Author

ahrtr commented Jan 28, 2025

also cc @neolit123

neolit123
neolit123 reviewed Jan 28, 2025
View reviewed changes
pkg/certificate/interface.go Outdated Show resolved Hide resolved
pkg/certificate/interface.go Outdated Show resolved Hide resolved
pkg/certificate/interface.go Outdated Show resolved Hide resolved
pkg/certificate/interface.go Outdated Show resolved Hide resolved
pkg/certificate/interface.go Outdated Show resolved Hide resolved
pkg/certificate/interface.go Outdated Show resolved Hide resolved
pkg/certificate/interface.go Outdated Show resolved Hide resolved
@ahrtr ahrtr force-pushed the cert_dir_20250128 branch from 4606835 to f93927e Compare January 28, 2025 20:02
@ahrtr
Copy link
Member Author

ahrtr commented Jan 28, 2025 •
edited
Loading

Resolved all comments from @neolit123 (Thanks).

@hakman @neolit123 @gdasson @ArkaSaha30 @jmhbnz @justinsb @jberkus PTAL, if there is no further comment, let's merge this PR soon.

@gdasson
Copy link
Member

gdasson commented Jan 28, 2025

@ahrtr : LGTM!

@ahrtr ahrtr force-pushed the cert_dir_20250128 branch from f93927e to ca14234 Compare January 29, 2025 09:13
@gdasson gdasson mentioned this pull request Jan 29, 2025
Closed
11 tasks
@ahrtr
Copy link
Member Author

ahrtr commented Jan 29, 2025

cc @jmhbnz @hakman

jmhbnz
jmhbnz approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 62a1908 into main Jan 30, 2025
5 checks passed
@ahrtr ahrtr deleted the cert_dir_20250128 branch January 30, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahrtr @gdasson @k8s-ci-robot @neolit123 @jmhbnz