Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed periodic compaction tests #18608

Merged

Conversation

srivastav-abhishek
Copy link
Contributor

…lt caused by time racing.

Signed-off-by: Joshua Zhang <[email protected]>

Addressed review comments

Co-authored-by: Abhishek Kr Srivastav <[email protected]>
Signed-off-by: Abhishek Kr Srivastav <[email protected]>
@k8s-ci-robot
Copy link

Hi @srivastav-abhishek. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Sep 19, 2024

/ok-to-test

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (2ed418c) to head (02aa317).
Report is 4 commits behind head on main.

Current head 02aa317 differs from pull request most recent head b8cb654

Please upload reports for the commit b8cb654 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18608      +/-   ##
==========================================
- Coverage   68.83%   68.80%   -0.03%     
==========================================
  Files         420      420              
  Lines       35474    35522      +48     
==========================================
+ Hits        24418    24441      +23     
- Misses       9636     9653      +17     
- Partials     1420     1428       +8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed418c...b8cb654. Read the comment docs.

@k8s-ci-robot
Copy link

@srivastav-abhishek: GitHub didn't allow me to request PR reviews from the following users: mkumatag, Rajalakshmi-Girish.

Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mkumatag @Rajalakshmi-Girish

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Many thanks for addressing these longstanding flakes @srivastav-abhishek

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is not my area of expertise, but the implementation looks good. Thanks, Abhishek.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, srivastav-abhishek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 2f9532b into etcd-io:main Sep 22, 2024
46 checks passed
@srivastav-abhishek srivastav-abhishek deleted the periodic-compaction-flake-fix branch September 23, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Flaky TestPeriodicHourly and TestPeriodicMinutes
7 participants