-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed periodic compaction tests #18608
Fixed periodic compaction tests #18608
Conversation
…lt caused by time racing. Signed-off-by: Joshua Zhang <[email protected]> Addressed review comments Co-authored-by: Abhishek Kr Srivastav <[email protected]> Signed-off-by: Abhishek Kr Srivastav <[email protected]>
Hi @srivastav-abhishek. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #18608 +/- ##
==========================================
- Coverage 68.83% 68.80% -0.03%
==========================================
Files 420 420
Lines 35474 35522 +48
==========================================
+ Hits 24418 24441 +23
- Misses 9636 9653 +17
- Partials 1420 1428 +8 Continue to review full report in Codecov by Sentry.
|
@srivastav-abhishek: GitHub didn't allow me to request PR reviews from the following users: mkumatag, Rajalakshmi-Girish. Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Many thanks for addressing these longstanding flakes @srivastav-abhishek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is not my area of expertise, but the implementation looks good. Thanks, Abhishek.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, srivastav-abhishek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #17054 and #17487
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.