-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nominate @fuweid as a new approver #19572
Conversation
Signed-off-by: Benjamin Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 19 files with indirect coverage changes @@ Coverage Diff @@
## main #19572 +/- ##
==========================================
+ Coverage 68.84% 68.85% +0.01%
==========================================
Files 421 421
Lines 35900 35900
==========================================
+ Hits 24716 24720 +4
+ Misses 9762 9758 -4
Partials 1422 1422 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well deserved, @fuweid! Thanks for all your contributions 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thank you @fuweid for the great contributions to the project for a long time!
Thank you @fuweid for your contribution to the etcd project!! :) |
Well deserved, @fuweid! Thanks for all your contributions! Congratulations! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, spzala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
+1 from me, thanks @fuweid for all your work. |
Awesome! Looks like we are all supportive! @fuweid Congrats on becoming an etcd approver! Well deserved. Your contributions are highly valued. As you step into this new role, "with great power comes great responsibility". Your decisions will directly impact the direction and health of etcd, and we rely on your sound judgment and collaborative spirit to guide us forward. Welcome onboard! |
Welcome onboard @fuweid ! Thanks again for your hard work and great contribution! Please raise a PR to add you into the |
Thanks all. I really appreciate the support! |
Fu Wei (@fuweid) has been actively contributing to etcd for the past 2–3 years. He (and also @ivanvc ) maintains a strong and effective collaboration with the community and tech leads. He not only has a deep understanding of etcd but has also played a key role in the development of v3.6.0. His contributions have been essential to a smooth release. I propose promoting him to etcd maintainer/approver.
All Fu Wei's PR: https://github.com/etcd-io/etcd/issues?q=state%3Aclosed%20is%3Apr%20author%3Afuweid
Proof of his expertise in etcd:
TestDowngradeCancellationAfterDowngrading2InClusterOf3
#19391 (comment)BTW, Fu Wei was nominated & promoted to a reviewer on Sep 25, 2023, refer to #16650
cc @jmhbnz @ivanvc @serathius @spzala @wenjiaswe