Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominate @fuweid as a new approver #19572

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Mar 11, 2025

Fu Wei (@fuweid) has been actively contributing to etcd for the past 2–3 years. He (and also @ivanvc ) maintains a strong and effective collaboration with the community and tech leads. He not only has a deep understanding of etcd but has also played a key role in the development of v3.6.0. His contributions have been essential to a smooth release. I propose promoting him to etcd maintainer/approver.

All Fu Wei's PR: https://github.com/etcd-io/etcd/issues?q=state%3Aclosed%20is%3Apr%20author%3Afuweid

Proof of his expertise in etcd:

  1. Resolved the missing delete event on watch: Missing delete event on watch opened on same revision as compaction request #19179
  2. Figured out the root cause of the flaky downgrade e2e test: Flaky TestDowngradeCancellationAfterDowngrading2InClusterOf3  #19391 (comment)
  3. Figured out the root cause why etcd sometimes generates a different hash when always writing exactly the same set of key/values: deflaky: TestSnapshotStatus #19313 (comment)
  4. Figured out the root cause of the flaky lease test case: tests: deflakey TestLeaseGrantTimeToLiveExpired #19476 (comment)
  5. Upgraded grpc-gateway from v1 to v2 together with me: Upgrade grpc-gateway from v1 to v2 #16595
  6. Fu Wei independently designed & implemented the bbolt robustness test

BTW, Fu Wei was nominated & promoted to a reviewer on Sep 25, 2023, refer to #16650

cc @jmhbnz @ivanvc @serathius @spzala @wenjiaswe

Signed-off-by: Benjamin Wang <[email protected]>
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (ffb6ff9) to head (4804c48).
Report is 8 commits behind head on main.

Additional details and impacted files

see 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19572      +/-   ##
==========================================
+ Coverage   68.84%   68.85%   +0.01%     
==========================================
  Files         421      421              
  Lines       35900    35900              
==========================================
+ Hits        24716    24720       +4     
+ Misses       9762     9758       -4     
  Partials     1422     1422              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb6ff9...4804c48. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well deserved, @fuweid! Thanks for all your contributions 😃

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thank you @fuweid for the great contributions to the project for a long time!

@henrybear327
Copy link
Contributor

Thank you @fuweid for your contribution to the etcd project!! :)

@siyuanfoundation
Copy link
Contributor

Well deserved, @fuweid! Thanks for all your contributions! Congratulations!

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this proposal @ahrtr, +1 from me.

@fuweid you have demonstrated great knowledge in key areas of etcd and your ongoing contributions to the project are very much appreciated. This recognition is well deserved, congratulations.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, spzala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahrtr,jmhbnz,spzala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member

+1 from me, thanks @fuweid for all your work.

@wenjiaswe
Copy link
Contributor

Awesome! Looks like we are all supportive!

@fuweid Congrats on becoming an etcd approver! Well deserved. Your contributions are highly valued.

As you step into this new role, "with great power comes great responsibility". Your decisions will directly impact the direction and health of etcd, and we rely on your sound judgment and collaborative spirit to guide us forward.

Welcome onboard!

@ahrtr
Copy link
Member Author

ahrtr commented Mar 13, 2025

Welcome onboard @fuweid ! Thanks again for your hard work and great contribution!

Please raise a PR to add you into the maintainers-etcd team.

https://github.com/kubernetes/org/blob/18b5f7715e523ee4893b95ea69df61e93e2a3c4b/config/etcd-io/sig-etcd/teams.yaml#L52

@ahrtr ahrtr merged commit a5bef1b into etcd-io:main Mar 13, 2025
33 checks passed
@fuweid
Copy link
Member

fuweid commented Mar 14, 2025

Thanks all. I really appreciate the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

10 participants