Update how-to-conduct-elections.md #889
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shubhdeep02 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @Shubhdeep02. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Thanks for raising this @Shubhdeep02, a few review items below to address 🙏🏻
|  | ||
| 1. The `etcdctl` command is used to conduct leader elections in an etcd cluster. It makes sure that only one client become leader at a time. | ||
| 2. Ensure the `ENDPOINTS` variable is set with the addresses of each etcd cluster members. | ||
| 3. Set a unique name for the election for different clients ('<i>one</i>' in the given code below). |
There was a problem hiding this comment.
Is there a reason for using html tags here for italics rather than standard markdown?
There was a problem hiding this comment.
Is there a reason for using html tags here for italics rather than standard markdown?
There wasn't any specific reason, I just wanted to emphasize the character for the reader's comfort. Should I change it??
There was a problem hiding this comment.
You can certainly add emphasis, but please do it using standard markdown, refer https://www.markdownguide.org/basic-syntax.
Signed-off-by: Shubhdeep02 <[email protected]>
Signed-off-by: Shubhdeep02 <[email protected]>
Signed-off-by: Shubhdeep02 <[email protected]>
Explanation improvement #787