refactor: Remove file I/O from deployment scripts #12015
+9
−254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mds1
reviewed
Sep 20, 2024
| @@ -18,15 +18,13 @@ import { BaseDeployIO } from "scripts/utils/BaseDeployIO.sol"; | |||
| // complement the OP Stack Manager. The script architecture is a bit different than a standard forge | |||
| // deployment script. | |||
| // | |||
| // There are three categories of users that are expected to interact with the scripts: | |||
| // 1. End users that want to run live contract deployments. | |||
There was a problem hiding this comment.
I think we should keep the end users item, but just indicate they are expected to run the scripts via op-deployer, which also uses the go interface
There was a problem hiding this comment.
Added here, 23fcc6c feel free to add more details if you have them to this. Otherwise, I can resolve and merge.
mds1
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes file I/O functionality from deployment scripts, simplifying the codebase and focusing on core deployment logic. Key changes include:
loadInputFileandwriteOutputFilemethods from various input and output contracts.runfunction that accepted file paths as arguments in deployment scripts.These changes streamline the deployment process, making it more suitable for direct programmatic use in Solidity and Go environments. The update maintains the existing core deployment logic while removing the complexity associated with file-based configurations.