-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts-bedrock): add batch message support to L2toL2CrossDomainMessenger #12019
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @tremarkley and the rest of your teammates on Graphite |
/// @notice Load a BatchableMessage from transient storage by index. | ||
/// @param index The index of the message to load. | ||
/// @return batchMessage The loaded BatchableMessage struct. | ||
function _loadMessage(uint256 index) internal view returns (BatchableMessage memory batchMessage) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Named return arguments to functions must be appended with an underscore (_
)
|
||
/// @notice Store batching status in transient storage. | ||
/// @param value The batching status. | ||
function _storeIsBatching(bool value) internal { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inputs to functions must be prepended with an underscore (_
)
|
||
/// @notice Clear a specific BatchableMessage stored in transient storage by index. | ||
/// @param index The index of the message to clear. | ||
function _clearMessage(uint256 index) internal { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inputs to functions must be prepended with an underscore (_
)
/// @notice Load a BatchableMessage from transient storage by index. | ||
/// @param index The index of the message to load. | ||
/// @return batchMessage The loaded BatchableMessage struct. | ||
function _loadMessage(uint256 index) internal view returns (BatchableMessage memory batchMessage) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inputs to functions must be prepended with an underscore (_
)
/** | ||
* @notice Clear all BatchableMessages stored in transient storage. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc-style comments are not allowed. Use ///
style doc comments instead.
Semgrep found 3
Do not use |
No description provided.