Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts-bedrock): add batch message support to L2toL2CrossDomainMessenger #12019

Closed
wants to merge 1 commit into from

Conversation

tremarkley
Copy link
Contributor

No description provided.

@tremarkley
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tremarkley and the rest of your teammates on Graphite Graphite

/// @notice Load a BatchableMessage from transient storage by index.
/// @param index The index of the message to load.
/// @return batchMessage The loaded BatchableMessage struct.
function _loadMessage(uint256 index) internal view returns (BatchableMessage memory batchMessage) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.


/// @notice Store batching status in transient storage.
/// @param value The batching status.
function _storeIsBatching(bool value) internal {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.


/// @notice Clear a specific BatchableMessage stored in transient storage by index.
/// @param index The index of the message to clear.
function _clearMessage(uint256 index) internal {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

/// @notice Load a BatchableMessage from transient storage by index.
/// @param index The index of the message to load.
/// @return batchMessage The loaded BatchableMessage struct.
function _loadMessage(uint256 index) internal view returns (BatchableMessage memory batchMessage) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

Comment on lines +434 to +436
/**
* @notice Clear all BatchableMessages stored in transient storage.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc-style comments are not allowed. Use /// style doc comments instead.

Ignore this finding from sol-style-doc-comment.

Copy link
Contributor

semgrep-app bot commented Sep 20, 2024

Semgrep found 3 math-random-used findings:

  • cannon/mipsevm/singlethreaded/testutil/state.go
  • cannon/mipsevm/multithreaded/testutil/thread.go
  • cannon/mipsevm/multithreaded/testutil/mutators.go

Do not use math/rand. Use crypto/rand instead.

Ignore this finding from math-random-used.

@tremarkley tremarkley closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant