Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ct): OPSM interfaces #12022

Closed
wants to merge 1 commit into from
Closed

feat(ct): OPSM interfaces #12022

wants to merge 1 commit into from

Conversation

smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Sep 20, 2024

Updates OPSM to use interfaces and updates Deploy.s.sol to use interfaces.

@smartcontracts smartcontracts force-pushed the sc/opsm-interfaces branch 2 times, most recently from 684d155 to 54bd819 Compare September 20, 2024 03:29
@smartcontracts smartcontracts changed the title wip: OPSM interfaces feat(ct): OPSM interfaces Sep 20, 2024
@smartcontracts smartcontracts marked this pull request as ready for review September 20, 2024 03:29
@smartcontracts smartcontracts requested a review from a team as a code owner September 20, 2024 03:29
@smartcontracts smartcontracts force-pushed the sc/opsm-interfaces branch 2 times, most recently from cce4865 to 0aef753 Compare September 20, 2024 03:49
Copy link
Contributor

semgrep-app bot commented Sep 20, 2024

Semgrep found 1 sol-style-return-arg-fmt finding:

  • packages/contracts-bedrock/src/universal/interfaces/IOptimismMintableERC721Factory.sol

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

@smartcontracts smartcontracts force-pushed the sc/opsm-interfaces branch 2 times, most recently from 6df23b7 to 46eda7d Compare September 20, 2024 04:16
One more big interface PR, converts OPSM to use interfaces and
fully updates Deploy.s.sol to use interfaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant