Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-150 #245

Merged
merged 3 commits into from
Nov 12, 2024
Merged

issue-150 #245

merged 3 commits into from
Nov 12, 2024

Conversation

Ethanol48
Copy link
Contributor

@Ethanol48 Ethanol48 commented Nov 2, 2024

Description
Follow-up of issue #150

Changed outdated first steps documentation.
also added more information about the contract address for more clarity for first users

The description described in the book does not work upon testing.
I wrote the method used in the video presentation

@Ethanol48 Ethanol48 requested a review from a team as a code owner November 2, 2024 13:10
@Ethanol48
Copy link
Contributor Author

Ethanol48 commented Nov 2, 2024

The addresses of the documentation were outdated, I first thought that the method was deprecated and following the tutorial from the README.md I added the method shown in the video.

exploring more the docs I noticed that the addresses of the contracts were wrong, I retried the first method with the correct contract and worked, so I then re-added the method with the correct contract address and added clarifications for the addresses as the doc seemed a bit vague about this matter.

Copy link
Contributor Author

@Ethanol48 Ethanol48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the method mentioned in the video

Copy link
Contributor

@jakim929 jakim929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@jakim929 jakim929 merged commit 922fe41 into ethereum-optimism:main Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants