core/tracing, core/vm: add ContractCode to the OpContext #30466
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to provide access to contract code feat(vm/interpreter.go): add ContractCode method to ScopeContext to return the code of the contract being executed
kchojn
requested review from
s1na,
karalabe,
holiman and
rjl493456442
as code owners
|
To add some extra context here: it is possible to get the code via statedb.GetCode but that wouldn't work for init code. |
s1na
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending the
OpContextinterface:ContractCode- returns the code of the contract being executed.Previous implementation of tracing had access to the contract code in Scope, the current one does not. And it was important in the context of custom tracers(e.g., in my case 👀).
So in reference to the conversation on discord (#tracing channel), I add such functionality.
I tried to follow the current naming convention, lmk if i should fix/change something!