Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libevmasm/EVMAssemblyStack.h: Remove unnecessary virtual specifier. #15697

Merged
merged 1 commit into from
Jan 9, 2025
Merged

libevmasm/EVMAssemblyStack.h: Remove unnecessary virtual specifier. #15697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions libevmasm/EVMAssemblyStack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,25 +50,25 @@ class EVMAssemblyStack: public AbstractAssemblyStack

std::string const& name() const { return m_name; }

virtual LinkerObject const& object(std::string const& _contractName) const override;
virtual LinkerObject const& runtimeObject(std::string const& _contractName) const override;
LinkerObject const& object(std::string const& _contractName) const override;
LinkerObject const& runtimeObject(std::string const& _contractName) const override;

std::shared_ptr<evmasm::Assembly> const& evmAssembly() const { return m_evmAssembly; }
std::shared_ptr<evmasm::Assembly> const& evmRuntimeAssembly() const { return m_evmRuntimeAssembly; }

virtual std::string const* sourceMapping(std::string const& _contractName) const override;
virtual std::string const* runtimeSourceMapping(std::string const& _contractName) const override;
std::string const* sourceMapping(std::string const& _contractName) const override;
std::string const* runtimeSourceMapping(std::string const& _contractName) const override;

virtual Json assemblyJSON(std::string const& _contractName) const override;
virtual std::string assemblyString(std::string const& _contractName, StringMap const& _sourceCodes) const override;
Json assemblyJSON(std::string const& _contractName) const override;
std::string assemblyString(std::string const& _contractName, StringMap const& _sourceCodes) const override;

virtual std::string const filesystemFriendlyName(std::string const& _contractName) const override;
std::string const filesystemFriendlyName(std::string const& _contractName) const override;

virtual std::vector<std::string> contractNames() const override { return {m_name}; }
virtual std::vector<std::string> sourceNames() const override;
std::vector<std::string> contractNames() const override { return {m_name}; }
std::vector<std::string> sourceNames() const override;
std::map<std::string, unsigned> sourceIndices() const;

virtual bool compilationSuccessful() const override { return m_evmAssembly != nullptr; }
bool compilationSuccessful() const override { return m_evmAssembly != nullptr; }

void selectDebugInfo(langutil::DebugInfoSelection _debugInfoSelection)
{
Expand Down
Loading