Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POST /v2/verify/{chainId}/{address} endpoint #2040

Merged
merged 22 commits into from
Apr 1, 2025

Conversation

manuelwedler
Copy link
Contributor

@manuelwedler manuelwedler commented Mar 26, 2025

Closes #1910

As specified in https://sourcify.stoplight.io/docs/sourcify-apiv2/h55xvo5bsu9qz-verify-contract-standard-json

Includes the needed verification worker which is implemented with the Piscina library.

See commit messages for details.

We should still do some testing on the worker configuration (number of threads, ...) and some benchmarking after this.

@manuelwedler manuelwedler force-pushed the apiv2-verify-endpoint branch from 5d820d5 to adc3ead Compare March 26, 2025 16:58
@manuelwedler
Copy link
Contributor Author

Some explanations:

  • The unknown_error was renamed to internal_error to match the specification.
  • I needed to make some changes to the SourcifyChainMap in order to pass its properties to the workers. That is why also some changes to the monitor are included.

Copy link
Member

@marcocastignoli marcocastignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉 I just added a few nitpicky comments that don't even have to be addressed. Just implement them if you also think they make sense.

@manuelwedler manuelwedler merged commit 1accdc1 into staging Apr 1, 2025
6 checks passed
@manuelwedler manuelwedler deleted the apiv2-verify-endpoint branch April 1, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint - Done
Development

Successfully merging this pull request may close these issues.

Implement POST /v2/verify/{chainId}/{address} endpoint
2 participants