Use EXPECT_CALL instead of ON_CALL for read_byte #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnor
changed the title
robinlinden
requested changes
Aug 29, 2019
johnor
force-pushed
the
use-expect-calls
branch
from
6303aa2 to
43e201a
Compare
Good idea! Updated now. |
robinlinden
approved these changes
Aug 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixing ON_CALL and EXPECT_CALL can be a bit tricky in gmock. We should also know exactly when reads are performed, so better to use EXPECT_CALL and be explicit everywhere.
Should help #107.