Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add squeaky-clean exercise #327

Merged
merged 2 commits into from
Feb 5, 2021
Merged

add squeaky-clean exercise #327

merged 2 commits into from
Feb 5, 2021

Conversation

bobbicodes
Copy link
Member

@bobbicodes bobbicodes commented Feb 4, 2021

Adds characters concept exercise, this PR replaces exercism/v3#2830 and is connected to issue #313 .

Moved all practice exercises to practice folder.

@bobbicodes bobbicodes requested review from a team and ErikSchierboom February 4, 2021 23:58
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. I would suggest merging this after #314 is merged today, otherwise there are a lot of unrelated changes.

@@ -0,0 +1,35 @@
(ns exercism.squeaky-clean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the exemplar file, in which case it should be located in the .meta directory.

@bobbicodes bobbicodes merged commit c783d3f into main Feb 5, 2021
@bobbicodes bobbicodes deleted the squeaky-clean branch February 5, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants