Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string literal comparison errors in bob_test.cpp #747

Closed
wants to merge 1 commit into from

Conversation

mgrubb
Copy link

@mgrubb mgrubb commented Dec 1, 2023

When comparing against string literals with == operator compiler throws /Users/mgrubb/Exercism/cpp/bob/bob_test.cpp:15:25: error: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Werror,-Wstring-compare] REQUIRE("Whatever." == bob::hey("Tom-ay-to, tom-aaaah-to."));

This prevents the tests from passing.
This change creates std::string constants to compare against.

When comparing against string literals with `==` operator compiler
throws `error: result of comparison against a string literal is unspecified`
error this prevents the tests from passing.
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Dec 1, 2023
@siebenschlaefer
Copy link
Contributor

Please discuss contributions like this in the forum first.

May I ask: What is the return type of hey in your function? It's probably not std::string nor std::string_view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants