Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle to 8 #470

Merged
merged 4 commits into from
Jan 25, 2025
Merged

Bump Gradle to 8 #470

merged 4 commits into from
Jan 25, 2025

Conversation

artamonovkirill
Copy link
Contributor

@artamonovkirill artamonovkirill commented Jan 20, 2025

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 20, 2025
@artamonovkirill
Copy link
Contributor Author

CI is expected to fall on "Validation" job, I haven't run ./gradlew wrapper task to not mix my and auto-generated changes.

@glennj
Copy link
Contributor

glennj commented Jan 21, 2025

LGTM. auto-generate away!

@artamonovkirill
Copy link
Contributor Author

CI is expected to fall on "Validation" job, I haven't run ./gradlew wrapper task not to mix my and auto-generated changes.

I was wrong, wrapper-validation GitHub actions only verifies gradle-wrapper.jar fires are not corrupted (by comparing checksums)

@artamonovkirill
Copy link
Contributor Author

We can add below two steps to the validation job to ensure the ./gradlew wrapper command was actually run:

      - uses: eskatos/gradle-command-action@ac2d340dc04d9e1113182899e983b5400c17cda1
        with:
          arguments: wrapper
      - run: git status --porcelain

@artamonovkirill artamonovkirill force-pushed the bump/gradle-8 branch 10 times, most recently from 1f3444e to b488aa4 Compare January 24, 2025 20:59
@artamonovkirill
Copy link
Contributor Author

artamonovkirill commented Jan 24, 2025

Those two commits are fully non-autogenerated: 03766df, bf594d7

This one is semi-generated, root gradle.bat got Windows-style endings by git: 1459542
It also ensures that the next commit is generated correctly.

This one (the biggest) is fully generated with ./gradlew wrapper: 8eee72a

@glennj glennj merged commit 14a5c6c into exercism:main Jan 25, 2025
5 checks passed
@artamonovkirill artamonovkirill deleted the bump/gradle-8 branch January 25, 2025 18:06
@artamonovkirill
Copy link
Contributor Author

@glennj thank you very much! 🙌

@glennj
Copy link
Contributor

glennj commented Jan 25, 2025

@artamonovkirill Thank you for putting in all this effort to modernize the track infrastructure.

I was having a quick look through the track docs to see if anything needed updating, but I don't think there is anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants