-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for first two tasks in Salary Calculator #2575
Conversation
… misspelled words.
…cted a misspelled word in the method name.
…use it tested implementation of the previous tasks). Cleaned the test file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up! I like the changes a lot already, just left a couple of comments to address.
Also, since your contributions to this exercise are non-trivial, feel free to add yourself as a contributor to the exercise's .meta/config.json
:
{
"authors": [
"TalesDias"
],
+ "contributors": [
+ "smicaliz"
+ ],
"files": {
"solution": [
"src/main/java/SalaryCalculator.java"
],
"test": [
"src/test/java/SalaryCalculatorTest.java"
],
"exemplar": [
".meta/src/reference/java/SalaryCalculator.java"
],
"invalidator": [
"build.gradle"
]
},
"blurb": "Learn about ternary operators by calculating salaries."
}
exercises/concept/salary-calculator/src/test/java/SalaryCalculatorTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/salary-calculator/src/test/java/SalaryCalculatorTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/salary-calculator/src/test/java/SalaryCalculatorTest.java
Show resolved
Hide resolved
…th the Exercism Markdown Specification. Some other corrections.
Updated! Ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the great work 😄
Closes #2573.
Wrote relevant test cases for task 1 and task 2 and removed some useless test cases for task 3 that tested implementation of the previous tasks and not only implementation of the task 3.
Updated the documentation for more clarity and readability and corrected some misspelled words.
Reviewer Resources:
Track Policies