Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for first two tasks in Salary Calculator #2575

Merged
merged 6 commits into from Nov 21, 2023
Merged

Add test cases for first two tasks in Salary Calculator #2575

merged 6 commits into from Nov 21, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 21, 2023

Closes #2573.

Wrote relevant test cases for task 1 and task 2 and removed some useless test cases for task 3 that tested implementation of the previous tasks and not only implementation of the task 3.

Updated the documentation for more clarity and readability and corrected some misspelled words.

Reviewer Resources:

Track Policies

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! I like the changes a lot already, just left a couple of comments to address.

Also, since your contributions to this exercise are non-trivial, feel free to add yourself as a contributor to the exercise's .meta/config.json:

{
  "authors": [
    "TalesDias"
  ],
+ "contributors": [
+   "smicaliz"
+ ],
  "files": {
    "solution": [
      "src/main/java/SalaryCalculator.java"
    ],
    "test": [
      "src/test/java/SalaryCalculatorTest.java"
    ],
    "exemplar": [
      ".meta/src/reference/java/SalaryCalculator.java"
    ],
    "invalidator": [
      "build.gradle"
    ]
  },
  "blurb": "Learn about ternary operators by calculating salaries."
}

…th the Exercism Markdown Specification. Some other corrections.
@ghost
Copy link
Author

ghost commented Nov 21, 2023

Updated! Ready to review.

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the great work 😄

@sanderploegsma sanderploegsma merged commit c466cc7 into exercism:main Nov 21, 2023
@ghost ghost deleted the add-test-cases-for-first-two-tasks-in-salary-calculator branch November 21, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test cases for first two tasks in Salary Calculator
1 participant