Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exercises/practice/anagram: add an append with instructions about the order of the return values #2904

Merged
merged 1 commit into from
Jan 16, 2025
Merged

exercises/practice/anagram: add an append with instructions about the order of the return values #2904

merged 1 commit into from
Jan 16, 2025

Conversation

IsaacG
Copy link
Member

@IsaacG IsaacG commented Jan 15, 2025

No description provided.

@IsaacG
Copy link
Member Author

IsaacG commented Jan 16, 2025

Clarify what this track expects. Context: https://forum.exercism.org/t/14816/

kahgoh
kahgoh requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @IsaacG , I think this is the incorrect append. It says that the order is important, but the assertions here containsExactlyInAnyOrder, which allows the anagrams to be listed in any order.

@IsaacG IsaacG force-pushed the anagram.append.return_order branch from b8c71e4 to a4ff4f1 Compare January 16, 2025 04:54
@IsaacG
Copy link
Member Author

IsaacG commented Jan 16, 2025

Hi @IsaacG , I think this is the incorrect append. It says that the order is important, but the assertions here containsExactlyInAnyOrder, which allows the anagrams to be listed in any order.

Apologies and thank you for catching that. I updated the PR.

@kahgoh kahgoh merged commit 7edff84 into exercism:main Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahgoh kahgoh kahgoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsaacG @kahgoh