Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate: format tests with edition 2024 #2035

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Feb 22, 2025

No description provided.

@senekor senekor requested a review from ellnix February 22, 2025 00:30
@senekor
Copy link
Contributor Author

senekor commented Feb 22, 2025

There's one test that makes sure test templates are in sync, that one is actually not run in CI (because it's slow, we might reconsider this) That test fails currently because the test generator tries to revert the formatting of the 2024 edition.

Copy link
Contributor

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed that it was bugged before and it's fixed after.

because it's slow, we might reconsider this

It doesn't seem that slow, it finished under 5s on my machine. Would probably be much faster in CI.

@senekor senekor merged commit 353ca9f into main Feb 22, 2025
12 checks passed
@senekor senekor deleted the senekor/rwkxpuuyorvl branch February 22, 2025 00:44
@senekor
Copy link
Contributor Author

senekor commented Feb 22, 2025

because it's slow, we might reconsider this

It doesn't seem that slow, it finished under 5s on my machine. Would probably be much faster in CI.

I think you're right. With a clean build, running tests in rust-tooling/ instead of rust-tooling/ci-tests/ increases total time locally from 15 to 25 seconds, so it doesn't seem excessively bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants