ocr_numbers & react: Sync missing tests

[ellnix]

No description provided.

[ellnix]

This test has a bizarre name in problem-specifications.

For convenience:

Rust version

#[test]
#[ignore]
fn callbacks_can_be_called_multiple_times() {
    let cb = CallbackRecorder::new();
    let mut reactor = Reactor::new();
    let input = reactor.create_input(1);
    let output = reactor
        .create_compute(&[CellId::Input(input)], |v| v[0] + 1)
        .unwrap();
    assert!(
        reactor
            .add_callback(output, |v| cb.callback_called(v))
            .is_some()
    );

    assert!(reactor.set_value(input, 2));
    cb.expect_to_have_been_called_with(3);
    assert!(reactor.set_value(input, 3));
    cb.expect_to_have_been_called_with(4);
}

Problem specifications

{
      "uuid": "ada17cb6-7332-448a-b934-e3d7495c13d3",
      "description": "callbacks do not report already reported values",
      "property": "react",
      "input": {
        "cells": [
          {
            "name": "input",
            "type": "input",
            "initial_value": 1
          },
          {
            "name": "output",
            "type": "compute",
            "inputs": ["input"],
            "compute_function": "inputs[0] + 1"
          }
        ],
        "operations": [
          {
            "type": "add_callback",
            "cell": "output",
            "name": "callback1"
          },
          {
            "type": "set_value",
            "cell": "input",
            "value": 2,
            "expect_callbacks": {
              "callback1": 3
            }
          },
          {
            "type": "set_value",
            "cell": "input",
            "value": 3,
            "expect_callbacks": {
              "callback1": 4
            }
          }
        ]
      },
      "expected": {}
    }

The procedure is the same in both cases and it matches the name of the rust test, but the problem-specifications description makes me think that there is a missing step.

Perhaps they forgot to add

          {
            "type": "set_value",
            "cell": "input",
            "value": 2,
            "expect_callbacks_not_to_be_called": [ "callback1" ]
          }

What do you think? Am I missing something obvious or should I bring this up in the forum?

[senekor]

Yeah that does look pretty weird. Doesn't match the description at all. Go ahead and post on the forum and please cc me.

[senekor]

I'm assuming you just checked that all the tests in the new tests.toml do in fact exist in the actual test file?

[ellnix]

I'm assuming you just checked that all the tests in the new tests.toml do in fact exist in the actual test file?

Yep, didn't write a template for these. ocr_numbers wouldn't be difficult but I don't think react would be worth the effort at all.