Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding roman numerals #445

Merged
merged 5 commits into from
Feb 1, 2025
Merged

Adding roman numerals #445

merged 5 commits into from
Feb 1, 2025

Conversation

keiravillekode
Copy link
Contributor

Based on @mk2s #383

kotp
kotp approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe when this is incorporated to main it will close the referenced pull request, but we will want to make sure. Also, we should take care that the originator gets their Reputation bump on the platform.

@keiravillekode keiravillekode merged commit 5a027b9 into exercism:main Feb 1, 2025
10 checks passed
@keiravillekode keiravillekode deleted the adding-roman-numerals branch February 1, 2025 00:57
@keiravillekode keiravillekode mentioned this pull request Feb 1, 2025
Closed
@keiravillekode
Copy link
Contributor Author

... we should take care that the originator gets their Reputation bump on the platform.

They will receive reputation bump as the author in config.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotp kotp kotp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keiravillekode @kotp @mk2s