Fix: Preserve non ascii characters when json.dumps and json.dump #1335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue related to the use of the
json.dumps
andjson.dump
methods in the prompt construction process. Currently, theensure_ascii
parameter is not set, which results in non-ASCII characters being escaped in the\uXXXX
format. This can hinder the LLM's ability to understand the intended language meaning.Changes Made
json.dumps
andjson.dump
methods calls to include the parameterensure_ascii=False
. This change will retain non-ASCII characters in their original form, improving the LLM's comprehension of the input.Impact
By allowing non-ASCII characters to remain unescaped, this modification will enhance the language processing capabilities of our model, leading to more accurate interpretations.
Sample Code
Before
After
Please let me know if there are any questions or further changes needed.