Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-tools] Flag doctor result as warning only for non-0 exit codes #513

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keith-kurak
Copy link

Why

After some updates to the Doctor output, all Doctor steps started showing as warnings on EAS Build logs. It turns out that it was matching on a specific output string in order to declare doctor steps as successful. This may have been necessary in the past, but Doctor now returns an exit code of 1 for any warnings that it would like to alert the user to.
(there are a few other ancillary messages that could be part of the output (such as skipped tests) in an exit code 0 scenario, but none rise to the "alert" level).

How

Removed the string check for "Didn't find any issues with the project". All non-exceptions from the async spawn should not flag as warnings now.

Test Plan

I've never worked in this code and don't know how to setup this repo for testing. However, I think testing would involve:

  • Build job with no Doctor warning: no warning on build logs
  • Build job with Doctor warnings: warning on build logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant