[build-tools] Flag doctor result as warning only for non-0 exit codes #513
+1
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
After some updates to the Doctor output, all Doctor steps started showing as warnings on EAS Build logs. It turns out that it was matching on a specific output string in order to declare doctor steps as successful. This may have been necessary in the past, but Doctor now returns an exit code of 1 for any warnings that it would like to alert the user to.
(there are a few other ancillary messages that could be part of the output (such as skipped tests) in an exit code 0 scenario, but none rise to the "alert" level).
How
Removed the string check for "Didn't find any issues with the project". All non-exceptions from the async spawn should not flag as warnings now.
Test Plan
I've never worked in this code and don't know how to setup this repo for testing. However, I think testing would involve: