Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update lint and config to be more consistent with other expo codebases #308

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Sep 19, 2024

Additional context

An indentation nit was raised in a previous PR: https://app.graphite.dev/github/pr/expo/expo-github-action/306/continuous-deploy-fingeprint-Output-whether-each-platform-build-was-created-or-one-was-reused#comment-PRRC_kwDOCaaLa85pRAUA

Lint should take care of this to reduce review responsibility. This updates prettier settings for that particular issue, but also updates lint to be more aligned with other node repos in the expo org.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite Graphite

@wschurman wschurman force-pushed the @wschurman/09-19-_chore_update_lint_and_config_to_be_more_consistent_with_other_expo_codebases branch from 424098f to ba9ed07 Compare September 19, 2024 18:34
@wschurman wschurman marked this pull request as ready for review September 19, 2024 18:35
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely work 👏

@wschurman wschurman merged commit 141e1af into main Sep 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants