[snackager] correct output with package type: module #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: expo#299 Refs: microsoft/rnx-kit#142 The Metro Babel preset does not produce correct output for packages containing "type": "module" unless the disableImportExportTransform options is used to prevent it from including @babel/plugin-transform-modules-commonjs
|
Thanks for the issue report and proposed fix! So far, I can confirm the issue. Now going to confirm if this fixes that, have to do that locally. |
|
Awesome, also confirmed your fix is working as intended for your package, so disregard the CI :). I'll try and find other packages with similar |
|
I even wonder if this should not be extended to all packages with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Refs: #299
Refs: microsoft/rnx-kit#142
The Metro Babel preset does not produce correct output
for packages containing "type": "module" unless
the
disableImportExportTransformoption is used toprevent it from including @babel/plugin-transform-modules-commonjs
fixes #299
How
I disable
disableImportExportTransformoption if I detect"type": "module"Test Plan
I included my module in the test suite