Refactor/performance #5406
Closed
Refactor/performance #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintonksang
commented
Jan 24, 2024
clintonksang
commented
- Updated Caching to improve performance
- Added Error handling on unspecified paths
UlisesGascon
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Hi @clintonksang! Thanks for this contribution. Can you elaborate a bit more the motivation for this change?
| delete this.settings['trust proxy fn']; | ||
| } | ||
|
|
||
| const appSettings = this.settings; |
There was a problem hiding this comment.
ES6 syntax is not supported in Express 4.x (main branch)
|
I'm going to close this because we never heard back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.