Skip to content

Commit

Permalink
remove broken shareble link feature
Browse files Browse the repository at this point in the history
Summary: This has been broken for over a year, see [comments](https://fb.workplace.com/groups/flippersupport/posts/1651007205379931/?comment_id=1875107449636571&reply_comment_id=1875591292921520)

Differential Revision: D59810879

fbshipit-source-id: 4b8e32d6a1ecabd2e68087db1d74add101c39b00
  • Loading branch information
antonk52 authored and facebook-github-bot committed Jul 16, 2024
1 parent 65c141d commit 8eafb06
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 258 deletions.
224 changes: 0 additions & 224 deletions desktop/flipper-ui/src/chrome/ShareSheetExportUrl.tsx

This file was deleted.

3 changes: 0 additions & 3 deletions desktop/flipper-ui/src/fb-stubs/constants.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ import {DeviceOS} from 'flipper-plugin';
export default Object.freeze({
IS_PUBLIC_BUILD: true,

// Enables the flipper data to be exported through shareabale link
ENABLE_SHAREABLE_LINK: false,

FEEDBACK_GROUP_LINK: 'https://github.com/facebook/flipper/issues',

// Workplace Group ID's
Expand Down
16 changes: 0 additions & 16 deletions desktop/flipper-ui/src/sandy-chrome/Navbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,9 @@ import {
ExportEverythingEverywhereAllAtOnceStatus,
startFileImport,
startFileExport,
startLinkExport,
} from '../utils/exportData';
import UpdateIndicator from '../chrome/UpdateIndicator';
import {css} from '@emotion/css';
import constants from '../fb-stubs/constants';
import {setStaticView} from '../reducers/connections';
import {StyleGuide} from './StyleGuide';
import {openDeeplinkDialog} from '../deeplink';
Expand Down Expand Up @@ -638,11 +636,6 @@ function ExtrasMenu() {
() => startFileExport(store.dispatch),
[store.dispatch],
);
const startLinkExportTracked = useTrackedCallback(
'Link export',
() => startLinkExport(store.dispatch),
[store.dispatch],
);
const startFileImportTracked = useTrackedCallback(
'File import',
() => startFileImport(store),
Expand Down Expand Up @@ -679,15 +672,6 @@ function ExtrasMenu() {
label: 'Export Flipper file',
onClick: startFileExportTracked,
},
...(constants.ENABLE_SHAREABLE_LINK
? [
{
key: 'exportShareableLink',
label: 'Export shareable link',
onClick: startLinkExportTracked,
},
]
: []),
{
type: 'divider',
},
Expand Down
16 changes: 1 addition & 15 deletions desktop/flipper-ui/src/utils/exportData.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import {processMessageQueue} from './messageQueue';
import {getPluginTitle} from './pluginUtils';
import {Dialog, getFlipperLib, Idler} from 'flipper-plugin';
import {ClientQuery} from 'flipper-common';
import ShareSheetExportUrl from '../chrome/ShareSheetExportUrl';
import ShareSheetExportFile from '../chrome/ShareSheetExportFile';
import ExportDataPluginSheet from '../chrome/ExportDataPluginSheet';
import {exportLogs} from '../chrome/ConsoleLogs';
Expand Down Expand Up @@ -456,7 +455,7 @@ async function getStoreExport(

export async function exportStore(
store: MiddlewareAPI,
includeSupportDetails?: boolean,
_includeSupportDetails?: boolean,
idler: Idler = new TestIdler(true),
statusUpdate: (msg: string) => void = () => {},
): Promise<{
Expand Down Expand Up @@ -755,19 +754,6 @@ export async function startFileExport(dispatch: Store['dispatch']) {
));
}

export async function startLinkExport(dispatch: Store['dispatch']) {
const plugins = await selectPlugins();
if (plugins === false) {
return; // cancelled
}
// TODO: no need to put this in the store,
// need to be cleaned up later in combination with SupportForm
dispatch(selectedPlugins(plugins));
Dialog.showModal((onHide) => (
<ShareSheetExportUrl onHide={onHide} logger={getLogger()} />
));
}

async function selectPlugins() {
return await Dialog.select<string[]>({
title: 'Select plugins to export',
Expand Down

0 comments on commit 8eafb06

Please sign in to comment.