-
Notifications
You must be signed in to change notification settings - Fork 958
ci: Use GITHUB_OUTPUT envvar instead of set-output command #5430
Conversation
`save-state` and `set-output` commands used in GitHub Actions are deprecated and [GitHub recommends using environment files](https://github.blog/changelog/2023-07-24-github-actions-update-on-save-state-and-set-output-commands/). This PR updates the usage of `set-output` to `$GITHUB_OUTPUT` Instructions for envvar usage from GitHub docs: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter
Thanks! I've been wanting to update that for a while! |
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@arunsathiya has updated the pull request. You must reimport the pull request before landing. |
@arunsathiya has updated the pull request. You must reimport the pull request before landing. |
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@arunsathiya It looks like something is still off for the Windows build. Could you take a look? |
Pull Request Test Coverage Report for Build 7616232349Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
@arunsathiya has updated the pull request. You must reimport the pull request before landing. |
It seems that Powershell commands need |
@arunsathiya has updated the pull request. You must reimport the pull request before landing. |
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
The windows runner still seems unhappy, unfortunately. |
@arunsathiya has updated the pull request. You must reimport the pull request before landing. |
I remember reviewing a bit two weeks but haven't gotten a chance to look again since. I'll take another look soon but would like the latest checks to run once. |
@arunsathiya has updated the pull request. You must reimport the pull request before landing. |
@arunsathiya has updated the pull request. You must reimport the pull request before landing. |
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
save-state
andset-output
commands used in GitHub Actions are deprecated and GitHub recommends using environment files.This PR updates the usage of
set-output
to$GITHUB_OUTPUT
Instructions for envvar usage from GitHub docs:
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter