Add support for overriding downsample mode per image request #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D62393210 |
This was referenced Sep 9, 2024
Reviewed By: yungsters Differential Revision: D62393210
|
This pull request was exported from Phabricator. Differential Revision: D62393210 |
Abbondanzo
force-pushed
the
export-D62393210
branch
from
9c8642e
to
e8e3aed
Compare
|
Closed by 9c57738 |
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Oct 7, 2024
Summary: ## Summary Fresco v3.3.0 contains necessary adjustments to allow downsample overrides per image request (see facebook/fresco#2787), as well as numerous other bug fixes and adjustments across both Drawee and Vito images. ## Changelog [Android][Changed] - Update Fresco from 3.2.0 to 3.3.0 Differential Revision: D63983051
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Oct 7, 2024
Summary: ## Summary Fresco v3.3.0 contains necessary adjustments to allow downsample overrides per image request (see facebook/fresco#2787), as well as numerous other bug fixes and adjustments across both Drawee and Vito images. ## Changelog [Android][Changed] - Update Fresco from 3.2.0 to 3.3.0 Differential Revision: D63983051
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 7, 2024
Summary: Pull Request resolved: #46864 ## Summary Fresco v3.3.0 contains necessary adjustments to allow downsample overrides per image request (see facebook/fresco#2787), as well as numerous other bug fixes and adjustments across both Drawee and Vito images. ## Changelog [Android][Changed] - Update Fresco from 3.2.0 to 3.3.0 Reviewed By: oprisnik Differential Revision: D63983051 fbshipit-source-id: 9ad0c40dfc864d24ffa39ca9e2bc0ddf8210f4f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fresco currently supports global configuration of downsampling modes via the
downsampleModesetting inImagePipelineConfig. However, it is not currently possible to support per-image downsample settings. Out of the box, the vast majority of images should be downsampled to avoid drawing images which are too large to be displayed on a canvas. Android will throw a runtime exception in such cases. Yet, there are some usages which warrant outright disabling of downsampling as detailed in great lengths in issues like this one and this one.This change introduces a new mechanism for overriding the globally-configured
downsampleModeper image request by using a newdownsampleOverridesetting. If the override value gets set to a non-nullDownsampleMode, theDecodeProducerwill use that override instead. If no override is set, the downsample mode configured from the pipeline is chosen.Examples
Here, you can see the subtle differences between two of the downsampling modes. These are applied via the new
downsampleOverridesetting. I have a follow-up PR that adds this to the showcase application.NEVERALWAYSDifferential Revision: D62393210