-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update intro-react.md #4083
base: main
Are you sure you want to change the base?
Update intro-react.md #4083
Conversation
updated the helper text, clarifying the usage of the react import
Hi @CoryHrycko! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
This comment was marked as resolved.
This comment was marked as resolved.
@Rexogamer, it shouldn't be needed. I use Typescript daily, and since React Native version 0.64, React Version 17, and I believe Typescript 4.1 we hadn't have to import that specific part. The current Typescript, version 5.4, playgrounds do not include these imports. For new projects this is not needed, unless the party needs to update global dependencies. Typescript is also separate from React, which both of us know, none the less I would update the linter dependencies in your project, and that should resolve any formatting issues. If you have some specific questions I will help. |
you'll also want to update |
Added, Thank you for the thorough review! As I read through you may see me again. 😄 |
Updated the helper text, clarifying the usage of the react import.