Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the CircleCI workflow to a GitHub Actions workflow #4121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jk0
Copy link

@jk0 jk0 commented May 17, 2024

Summary

This pull request converts the CircleCI workflows to GitHub actions workflows. Github Actions Importer was used to convert the workflows initially, then I edited them manually to correct errors in translation.

Issues

  1. facebook/react-native-website/tests -> lint
error Command "ci:lint" not found.
  1. facebook/react-native-website/tests -> build
error Command "build" not found.

How did you test this change?

I tested these changes in a forked repo.

https://fburl.com/workplace/f6mz6tmw

Copy link

netlify bot commented May 17, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 2b5f085
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/6647952890bd0a00082231ea
😎 Deploy Preview https://deploy-preview-4121--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- uses: borales/actions-yarn@v4
with:
cmd: install
- uses: borales/actions-yarn@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an external action here? (Q valid for the whole workflow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants