docs: remove outdated tv docs #4155
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@Simek any thoughts on this one? |
|
Let's make sure that @douglowder is fine with that change, and if wiki is a right place to redirect people. |
|
@Simek the official react-native-tvos documentation links to their wiki, thats why I decided to add this link |
|
I have in mind that we might want to split up the redirected group, between those, who use frameworks and those who are not, like we do in new setup environment sections. For example, for Expo users, we got a dedicated guide on how to build TV apps - https://docs.expo.dev/guides/building-for-tv/ - which is also referenced in the wiki links, and that way we might spare user a link jump. Also, RN TV wiki seems to contains only one doc page, and rest are an external links do different resources, so it might be more valuable to link people into the doc file directly, which will guide them through the setup. |
|
@Simek Sure, provide me please information on which of these two options we prefer. I would also like to note that if we redirect to TV Wiki, we won't have to worry about updating this subpage in the future, as all TV-related information will be then updated by the react-native-tvos community in their repo |
There was a problem hiding this comment.
See my comments 😄 and thanks for doing this!
Note the related earlier change: #3958
|
@douglowder done ;)) Should i update earlier docs versions? |
@moskalakamil yes thanks, just the versions that Meta currently supports (I think that is 0.71 and up) |
|
@douglowder finished, thanks for guidance! |
|
@moskalakamil no problem! I approve the request, although I don't have access to do that in GitHub 😄 |
There was a problem hiding this comment.
Thanks for the Feedback Doug, and @moskalakamil for the updates! 🙏
Left one last suggestion about the link, but but we also can ship as-is.
|
@Simek updated 👍 |
|
Hey @Simek, just following up on my PR — it’s been sitting for a while. Thanks! |
|
Oh, sorry for missing that one, and thanks for the ping! 🙏 One last thing before shipping, can we also update the file for 0.75 release, so we got a full coverage? |
|
Sure! I’ve done this @Simek |
Since React Native for TV has been moved to a separate repository, information on how to develop for this library should not be included in the main React Native documentation. We should either remove this section entirely or add a link redirecting users to the react-native-tvos Wiki.