Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image.md fresco GIF library version #4196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coderBeat
Copy link

with react-native 0.75, this library doesn't work:

  // For animated GIF support
  implementation 'com.facebook.fresco:animated-gif:3.1.3'

We need to switch to the latest library:

    // For animated GIF support
    implementation 'com.facebook.fresco:animated-gif:3.2.0'

with react-native 0.75, this library doesn't work:

  // For animated GIF support
  implementation 'com.facebook.fresco:animated-gif:3.1.3'

We need to switch to the latest library:
    // For animated GIF support
    implementation 'com.facebook.fresco:animated-gif:3.2.0'
@facebook-github-bot
Copy link

Hi @coderBeat!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 3adf34b
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/66c5dd127521920008377e01
😎 Deploy Preview https://deploy-preview-4196--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the version of animated-webp and websupport to 3.2.0?

Also can we apply the same change to the versioned docs?

@@ -98,7 +98,7 @@ dependencies {
implementation 'com.facebook.fresco:animated-base-support:1.3.0'

// For animated GIF support
implementation 'com.facebook.fresco:animated-gif:3.1.3'
implementation 'com.facebook.fresco:animated-gif:3.2.0'

// For WebP support, including animated WebP
implementation 'com.facebook.fresco:animated-webp:3.1.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
implementation 'com.facebook.fresco:animated-webp:3.1.3'
implementation 'com.facebook.fresco:animated-webp:3.2.0'

@coderBeat
Copy link
Author

I thought about that,
but I only tested the GIF support, I don't have any idea about the rest.

@cortinico
Copy link
Contributor

I thought about that, but I only tested the GIF support, I don't have any idea about the rest.

They do update in a lockstep so I'd rather keep them aligned rather than recommending mixed version of Fresco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants