Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance on deps to the contributing guide #4217

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

huntie
Copy link
Member

@huntie huntie commented Sep 16, 2024

Summary

Supports facebook/react-native#46420 (see discussion).

  • Add Yarn install instructions.
  • Add instructions for building react-native-codegen.
  • Remove duplicated set of steps from contributing-overview.md — these are a subset of the step-by-step guide and were drifting out of sync.

Test plan

image

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 57126cc
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/66e84624ab1eec00086697a8
😎 Deploy Preview https://deploy-preview-4217--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@huntie huntie merged commit 7a90bb5 into facebook:main Sep 16, 2024
4 checks passed
@huntie huntie deleted the update-contributing-docs branch September 16, 2024 15:27
@Saadnajmi
Copy link
Contributor

Thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants