Support customizeRootView from RCTRootViewFactory #44775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: bb61e07 |
|
Thanks for the PR, but I don't think we need this, @Kudo. We moved the Perhaps I'm missing something, but why we need to bring this customization into the RootView Factory? |
|
@cipolleschi thanks for feedback. this is to resolve the issue when enable new architecture with react-native-bootsplash and expo-updates. there is a workaround patch in react-conf-app but i think it would be good to have the feature in RCTRootViewFactory, so that developers reuse RCTRootViewFactory can fully support customizeRootView. we could apply the patch inside expo-modules-core if you think RCTRootViewFactory is not the right place. more details: expo-updates will delay the timing to initialize react instance and create an empty root view rather than the RCTRootView. we need to show splash screen twice. one before empty root view and the other after we use RCTRootViewFactory to create the formal RCTRootView. react-native-bootsplash uses customizeRootView to setup and show splash screen twice. that's why we need customizeRootView to be supported from RCTRootViewFactory (or our derived EXReactRootViewFactory) |
Kudo
force-pushed
the
@kudo/RCTRootViewFactory-customizeRootView
branch
from
4d2aedb
to
8b54ed7
Compare
cipolleschi
approved these changes
Jun 5, 2024
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 8956869. |
|
This pull request was successfully merged by @Kudo in 8956869. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: The new `customizeRootView` does not have the feature parity as `createRootViewWithBridge` where reusing RCTRootViewFactory to create a root view, it does not call `customizeRootView`. This PR moves the `customizeRootView` support from RCTAppDelegate into RCTRootViewFactory and improves the customizeRootView support. ## Changelog: [IOS] [CHANGED] - Support `customizeRootView` from `RCTRootViewFactory` Pull Request resolved: facebook#44775 Test Plan: Add customizeRootView to **packages/rn-tester/RNTester/AppDelegate.mm** and test whether RNTester has blue background color in both new arch and old arch mode. ```objc - (void)customizeRootView:(RCTRootView *)rootView { rootView.backgroundColor = [UIColor blueColor]; } ``` Reviewed By: dmytrorykun Differential Revision: D58179693 Pulled By: cipolleschi fbshipit-source-id: 0fac9a1bd5b2583a2700b3a3d2c80d0f608c4481
Titozzz
pushed a commit
that referenced
this pull request
Jun 18, 2024
Summary: The new `customizeRootView` does not have the feature parity as `createRootViewWithBridge` where reusing RCTRootViewFactory to create a root view, it does not call `customizeRootView`. This PR moves the `customizeRootView` support from RCTAppDelegate into RCTRootViewFactory and improves the customizeRootView support. [IOS] [CHANGED] - Support `customizeRootView` from `RCTRootViewFactory` Pull Request resolved: #44775 Test Plan: Add customizeRootView to **packages/rn-tester/RNTester/AppDelegate.mm** and test whether RNTester has blue background color in both new arch and old arch mode. ```objc - (void)customizeRootView:(RCTRootView *)rootView { rootView.backgroundColor = [UIColor blueColor]; } ``` Reviewed By: dmytrorykun Differential Revision: D58179693 Pulled By: cipolleschi fbshipit-source-id: 0fac9a1bd5b2583a2700b3a3d2c80d0f608c4481
Titozzz
pushed a commit
that referenced
this pull request
Jun 18, 2024
Summary: The new `customizeRootView` does not have the feature parity as `createRootViewWithBridge` where reusing RCTRootViewFactory to create a root view, it does not call `customizeRootView`. This PR moves the `customizeRootView` support from RCTAppDelegate into RCTRootViewFactory and improves the customizeRootView support. [IOS] [CHANGED] - Support `customizeRootView` from `RCTRootViewFactory` Pull Request resolved: #44775 Test Plan: Add customizeRootView to **packages/rn-tester/RNTester/AppDelegate.mm** and test whether RNTester has blue background color in both new arch and old arch mode. ```objc - (void)customizeRootView:(RCTRootView *)rootView { rootView.backgroundColor = [UIColor blueColor]; } ``` Reviewed By: dmytrorykun Differential Revision: D58179693 Pulled By: cipolleschi fbshipit-source-id: 0fac9a1bd5b2583a2700b3a3d2c80d0f608c4481
Titozzz
pushed a commit
that referenced
this pull request
Jun 18, 2024
Summary: The new `customizeRootView` does not have the feature parity as `createRootViewWithBridge` where reusing RCTRootViewFactory to create a root view, it does not call `customizeRootView`. This PR moves the `customizeRootView` support from RCTAppDelegate into RCTRootViewFactory and improves the customizeRootView support. [IOS] [CHANGED] - Support `customizeRootView` from `RCTRootViewFactory` Pull Request resolved: #44775 Test Plan: Add customizeRootView to **packages/rn-tester/RNTester/AppDelegate.mm** and test whether RNTester has blue background color in both new arch and old arch mode. ```objc - (void)customizeRootView:(RCTRootView *)rootView { rootView.backgroundColor = [UIColor blueColor]; } ``` Reviewed By: dmytrorykun Differential Revision: D58179693 Pulled By: cipolleschi fbshipit-source-id: 0fac9a1bd5b2583a2700b3a3d2c80d0f608c4481
|
@cipolleschi @Kudo Does a 0.74.x version with this fix is planned? |
|
yes, it was already picked reactwg/react-native-releases#312, would be available from next version |
Merged
3 tasks
Kudo
added a commit
to expo/expo
that referenced
this pull request
Jul 6, 2024
# Why react-native 0.74.3 added `customizeRootView` support from facebook/react-native#44775. we should clone the code from `RCTAppDelegate.createRCTRootViewFactory` to our `EXAppDelegateWrapper.createRCTRootViewFactory` that could possibly fix react-native-bootsplash integration for zoontek/react-native-bootsplash#590 # How - reference https://github.com/facebook/react-native/blob/8c8c77b974ce3d4c3036361e56276a6ff2b02208/packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm#L238-L262 to copy to `EXAppDelegateWrapper.createRCTRootViewFactory` - since we are still on 0.74.2, we should use `respondsToSelector` to check the existing property from RCTRootViewFactoryConfiguration.
Kudo
added a commit
to expo/expo
that referenced
this pull request
Jul 6, 2024
react-native 0.74.3 added `customizeRootView` support from facebook/react-native#44775. we should clone the code from `RCTAppDelegate.createRCTRootViewFactory` to our `EXAppDelegateWrapper.createRCTRootViewFactory` that could possibly fix react-native-bootsplash integration for zoontek/react-native-bootsplash#590 - reference https://github.com/facebook/react-native/blob/8c8c77b974ce3d4c3036361e56276a6ff2b02208/packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm#L238-L262 to copy to `EXAppDelegateWrapper.createRCTRootViewFactory` - since we are still on 0.74.2, we should use `respondsToSelector` to check the existing property from RCTRootViewFactoryConfiguration. (cherry picked from commit 7c7499a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The new
customizeRootViewdoes not have the feature parity ascreateRootViewWithBridgewhere reusing RCTRootViewFactory to create a root view, it does not callcustomizeRootView. This PR moves thecustomizeRootViewsupport from RCTAppDelegate into RCTRootViewFactory and improves the customizeRootView support.Changelog:
[IOS] [CHANGED] - Support
customizeRootViewfromRCTRootViewFactoryTest Plan:
Add customizeRootView to packages/rn-tester/RNTester/AppDelegate.mm and test whether RNTester has blue background color in both new arch and old arch mode.