Fix status bar height calculation for all cutout sizes #44805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58088036 |
Base commit: ce10ce4 |
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 5, 2024
Summary: Google has discouraged attempting to read the `status_bar_height` resource [since 2017](https://youtu.be/_mGDMVRO3iE?si=qGQd7gLa_qTmfLGL&t=1079). With the introduction of display cutouts there can be a mismatch between the resource value and the true status bar size (and issues like [this one](facebook#33612) popped up). The recommended approach is to instead call `getInsets` with the proper status bar and navigation flags provided by `WindowInsets`. On older APIs where `getInsets` is not supported, we have access to `systemWindowInsetTop`. Changelog: [Android][Fixed] - Fixed StatusBar.currentHeight calculations to honor all cutout sizes Differential Revision: D58088036
Abbondanzo
force-pushed
the
export-D58088036
branch
from
f462726
to
76e658c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58088036 |
Summary: Google has discouraged attempting to read the `status_bar_height` resource [since 2017](https://youtu.be/_mGDMVRO3iE?si=qGQd7gLa_qTmfLGL&t=1079). With the introduction of display cutouts there can be a mismatch between the resource value and the true status bar size (and issues like [this one](facebook#33612) popped up). The recommended approach is to instead call `getInsets` with the proper status bar and navigation flags provided by `WindowInsets`. On older APIs where `getInsets` is not supported, we have access to `systemWindowInsetTop`. Changelog: [Android][Fixed] - Fixed StatusBar.currentHeight calculations to honor all cutout sizes Reviewed By: tdn120 Differential Revision: D58088036
Abbondanzo
force-pushed
the
export-D58088036
branch
from
76e658c
to
b734645
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58088036 |
|
This pull request has been merged in 0b8222a. |
|
This pull request was successfully merged by Peter Abbondanzo in 0b8222a. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Google has discouraged attempting to read the
status_bar_heightresource since 2017. With the introduction of display cutouts there can be a mismatch between the resource value and the true status bar size (and issues like this one popped up). The recommended approach is to instead callgetInsetswith the proper status bar and navigation flags provided byWindowInsets. On older APIs wheregetInsetsis not supported, we have access tosystemWindowInsetTop.Changelog:
[Android][Fixed] - Fixed StatusBar.currentHeight calculations to honor all cutout sizes
Differential Revision: D58088036