Add EventEmitter C++ bridging type #44808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57424391 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 5, 2024
Summary:
Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.
Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
```
export type EventEmitter<T> = {
addListener(handler: (T) => mixed): EventSubscription,
};
```
## Hybrid
It is a 'hybrid' object.
1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code)
2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript)
## Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
## Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391
christophpurrer
force-pushed
the
export-D57424391
branch
from
b4a201a
to
d56e25f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57424391 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 5, 2024
Summary:
Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.
Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
```
export type EventEmitter<T> = {
addListener(handler: (T) => mixed): EventSubscription,
};
```
## Hybrid
It is a 'hybrid' object.
1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code)
2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript)
## Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
## Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391
christophpurrer
force-pushed
the
export-D57424391
branch
from
d56e25f
to
359d333
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57424391 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 5, 2024
Summary:
Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.
Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
```
export type EventEmitter<T> = {
addListener(handler: (T) => mixed): EventSubscription,
};
```
## Hybrid
It is a 'hybrid' object.
1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code)
2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript)
## Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
## Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 5, 2024
Summary:
Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.
Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
```
export type EventEmitter<T> = {
addListener(handler: (T) => mixed): EventSubscription,
};
```
## Hybrid
It is a 'hybrid' object.
1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code)
2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript)
## Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
## Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391
Base commit: 53dda9e |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 6, 2024
Summary:
Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.
Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
```
export type EventEmitter<T> = {
addListener(handler: (T) => mixed): EventSubscription,
};
```
## Hybrid
It is a 'hybrid' object.
1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code)
2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript)
## Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
## Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391
christophpurrer
force-pushed
the
export-D57424391
branch
from
359d333
to
840b191
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57424391 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 6, 2024
Summary:
Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.
Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
```
export type EventEmitter<T> = {
addListener(handler: (T) => mixed): EventSubscription,
};
```
## Hybrid
It is a 'hybrid' object.
1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code)
2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript)
## Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
## Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391
christophpurrer
force-pushed
the
export-D57424391
branch
from
840b191
to
1aa93e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57424391 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 6, 2024
Summary:
Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.
Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
```
export type EventEmitter<T> = {
addListener(handler: (T) => mixed): EventSubscription,
};
```
## Hybrid
It is a 'hybrid' object.
1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code)
2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript)
## Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
## Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 6, 2024
Summary:
Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.
Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
```
export type EventEmitter<T> = {
addListener(handler: (T) => mixed): EventSubscription,
};
```
## Hybrid
It is a 'hybrid' object.
1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code)
2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript)
## Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
## Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 6, 2024
Summary:
Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.
Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
```
export type EventEmitter<T> = {
addListener(handler: (T) => mixed): EventSubscription,
};
```
## Hybrid
It is a 'hybrid' object.
1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code)
2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript)
## Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
## Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391
christophpurrer
force-pushed
the
export-D57424391
branch
from
1aa93e0
to
60c70ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57424391 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 6, 2024
Summary:
Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.
Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
```
export type EventEmitter<T> = {
addListener(handler: (T) => mixed): EventSubscription,
};
```
## Hybrid
It is a 'hybrid' object.
1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code)
2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript)
## Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
## Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 6, 2024
Summary:
Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.
Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
```
export type EventEmitter<T> = {
addListener(handler: (T) => mixed): EventSubscription,
};
```
## Hybrid
It is a 'hybrid' object.
1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code)
2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript)
## Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
## Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391
|
This pull request was exported from Phabricator. Differential Revision: D57424391 |
christophpurrer
force-pushed
the
export-D57424391
branch
from
60c70ad
to
c1ce102
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 8, 2024
Summary: Pull Request resolved: facebook#44808 Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript. Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought. It implements this interface ``` export type EventEmitter<T> = { addListener(handler: (T) => mixed): EventSubscription, }; ``` ## Hybrid It is a 'hybrid' object. 1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code) 2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript) ## Changelog: [General] [Added] - Add EventEmitter C++ bridging type ## Facebook: Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h Reviewed By: javache Differential Revision: D57424391
|
This pull request was exported from Phabricator. Differential Revision: D57424391 |
christophpurrer
force-pushed
the
export-D57424391
branch
from
c1ce102
to
a7ea167
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 9, 2024
Summary: Pull Request resolved: facebook#44808 Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript. Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought. It implements this interface ``` export type EventEmitter<T> = { addListener(handler: (T) => mixed): EventSubscription, }; ``` ## Hybrid It is a 'hybrid' object. 1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code) 2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript) ## Changelog: [General] [Added] - Add EventEmitter C++ bridging type ## Facebook: Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h Reviewed By: javache Differential Revision: D57424391
|
This pull request was exported from Phabricator. Differential Revision: D57424391 |
christophpurrer
force-pushed
the
export-D57424391
branch
from
a7ea167
to
aa73b29
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 10, 2024
Summary: Pull Request resolved: facebook#44808 Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript. Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought. It implements this interface ``` export type EventEmitter<T> = { addListener(handler: (T) => mixed): EventSubscription, }; ``` ## Hybrid It is a 'hybrid' object. 1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code) 2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript) ## Changelog: [General] [Added] - Add EventEmitter C++ bridging type ## Facebook: Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h Reviewed By: javache Differential Revision: D57424391
Summary: Pull Request resolved: facebook#44808 Adds an `AsyncEventEmitter` class which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript. Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought. It implements this interface ``` export type EventEmitter<T> = { addListener(handler: (T) => mixed): EventSubscription, }; ``` ## Hybrid It is a 'hybrid' object. 1.) You `addListener(handler: (T) => mixed)` in JavaScript for emitted events (coming from C++, native code) 2.) You `emit(...Arg)` events in C++, native code (getting sent to JavaScript) ## Changelog: [General] [Added] - Add EventEmitter C++ bridging type ## Facebook: Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h Reviewed By: javache Differential Revision: D57424391
|
This pull request was exported from Phabricator. Differential Revision: D57424391 |
christophpurrer
force-pushed
the
export-D57424391
branch
from
aa73b29
to
e9062c6
Compare
|
This pull request has been merged in 2a0a112. |
|
This pull request was successfully merged by @christophpurrer in 2a0a112. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds an
AsyncEventEmitterclass which can be used as a property of currently C++ only Turbo Modules to send type safe data back to JavaScript.Adding support for ObjC / Java Turbo Modules is possible, straight forward and can be added as an afterthought.
It implements this interface
Hybrid
It is a 'hybrid' object.
1.) You
addListener(handler: (T) => mixed)in JavaScript for emitted events (coming from C++, native code)2.) You
emit(...Arg)events in C++, native code (getting sent to JavaScript)Changelog:
[General] [Added] - Add EventEmitter C++ bridging type
Facebook:
Apps usually create custom functionality to achieve this kind of behavior - e.g. https://www.internalfb.com/code/fbsource/[e72bd42a028a]/arvr/js/apps/RemoteDesktopCompanion/shared/turbo_modules/TMSubscription.h
Differential Revision: D57424391