swap test_ios_template for test_ios_helloworld in CircleCI (#44497) #44815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57122797 |
Base commit: ce10ce4 |
blakef
added a commit
to blakef/react-native
that referenced
this pull request
Jun 6, 2024
…44815) Summary: Remove our `test_ios_template` job for `test_ios_helloworld`. NOTE: There needs to be a followup to do the same in our Github Actions. Changelog: [General][Changed] use helloworld instead of template for CI tests. Reviewed By: cipolleschi Differential Revision: D57122797
|
This pull request was exported from Phabricator. Differential Revision: D57122797 |
blakef
added a commit
to blakef/react-native
that referenced
this pull request
Jun 6, 2024
…44815) Summary: Remove our `test_ios_template` job for `test_ios_helloworld`. NOTE: There needs to be a followup to do the same in our Github Actions. Changelog: [General][Changed] use helloworld instead of template for CI tests. Reviewed By: cipolleschi Differential Revision: D57122797
|
This pull request was exported from Phabricator. Differential Revision: D57122797 |
blakef
added a commit
to blakef/react-native
that referenced
this pull request
Jun 6, 2024
…44815) Summary: Remove our `test_ios_template` job for `test_ios_helloworld`. NOTE: There needs to be a followup to do the same in our Github Actions. Changelog: [General][Changed] use helloworld instead of template for CI tests. Reviewed By: cipolleschi Differential Revision: D57122797
|
This pull request was exported from Phabricator. Differential Revision: D57122797 |
blakef
added a commit
to blakef/react-native
that referenced
this pull request
Jun 6, 2024
…44815) Summary: Remove our `test_ios_template` job for `test_ios_helloworld`. NOTE: There needs to be a followup to do the same in our Github Actions. Changelog: [General][Changed] use helloworld instead of template for CI tests. Reviewed By: cipolleschi Differential Revision: D57122797
|
This pull request was exported from Phabricator. Differential Revision: D57122797 |
blakef
added a commit
to blakef/react-native
that referenced
this pull request
Jun 6, 2024
…44815) Summary: Remove our `test_ios_template` job for `test_ios_helloworld`. NOTE: There needs to be a followup to do the same in our Github Actions. Changelog: [General][Changed] use helloworld instead of template for CI tests. Reviewed By: cipolleschi Differential Revision: D57122797
|
This pull request was exported from Phabricator. Differential Revision: D57122797 |
…44815) Summary: Remove our `test_ios_template` job for `test_ios_helloworld`. NOTE: There needs to be a followup to do the same in our Github Actions. Changelog: [General][Changed] use helloworld instead of template for CI tests. Reviewed By: cipolleschi Differential Revision: D57122797
|
This pull request was exported from Phabricator. Differential Revision: D57122797 |
|
This pull request has been merged in b5fd041. |
|
This pull request was successfully merged by @blakef in b5fd041. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…44815) Summary: Pull Request resolved: facebook#44815 Remove our `test_ios_template` job for `test_ios_helloworld`. NOTE: There needs to be a followup to do the same in our Github Actions. Changelog: [General][Changed] use helloworld instead of template for CI tests. Reviewed By: cipolleschi Differential Revision: D57122797 fbshipit-source-id: 744c79230b716716fdfc234832f1eb241e091893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove our
test_ios_templatejob fortest_ios_helloworld.NOTE: There needs to be a followup to do the same in our Github Actions.
Changelog: [General][Changed] use helloworld instead of template for CI tests.
Reviewed By: cipolleschi
Differential Revision: D57122797