fix: minor fixes for hermes scripts #45841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
okwasniewski
force-pushed
the
fix/hermes-scripts
branch
from
5d75cef
to
37a3a69
Compare
facebook-github-bot
added
the
Shared with Meta
okwasniewski
force-pushed
the
fix/hermes-scripts
branch
from
37a3a69
to
bb7670b
Compare
cipolleschi
reviewed
Jul 31, 2024
cipolleschi
requested changes
Jul 31, 2024
packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh
Outdated
Show resolved
Hide resolved
okwasniewski
force-pushed
the
fix/hermes-scripts
branch
from
bb7670b
to
7384cd7
Compare
|
@okwasniewski this targets this, correct? (just trying to link them in gh) |
|
Not really, this is a PR with additional fixes that will prevent this happening in the future, we are working together with @cipolleschi here: #45840 |
|
Hey @cipolleschi is this one good to merge or should I do some additional changes? |
cipolleschi
approved these changes
Aug 7, 2024
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in c17da4e. |
|
This pull request was successfully merged by @okwasniewski in c17da4e When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes few issues with Hermes scripts:
Changelog:
[INTERNAL] [FIXED] - Hermes script should fail when no deployment target is set
Test Plan:
Try to build Hermes