Fix GH-41226

[knappam]

When not drawing a border, the mGapBetweenPaths adjustment can create noticeable pixelation when drawing curves through a low number of pixels. This is noticeable mostly on buttons and such on low-dpi devices. This fix only applies the fix if clipping for the border radius is done.

Summary:

When drawing small radius rounded backgrounds (e.g. to draw a circle or button) we see visible pixelation. This is particularly noticable on low DPI devices.

Changelog:

[ANDROID] [FIXED] - Don't use mGapBetweenPaths if not drawing a border

Test Plan:

Built an android app that directly uses ReactViewBackgroundDrawable to draw a background and verified repro of this issue.

Then modified the code according to this PR and verified that anti-aliasing is appropriately applied

[facebook-github-bot]

Hi @knappam!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,492,507	-12,862,349
android	hermes	armeabi-v7a	7810577	n/a
android	hermes	x86	8962965	n/a
android	hermes	x86_64	8823940	n/a
android	jsc	arm64-v8a	9,151,844	-15,398,147
android	jsc	armeabi-v7a	8341472	n/a
android	jsc	x86	9205131	n/a
android	jsc	x86_64	9463803	n/a

Base commit: fcd526d
Branch: main

[NickGerleman]

The base of this PR is many months old. Please rebase.