-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/blob/BlobModule.java #50364
Open
GijsWeterings
wants to merge
19
commits into
facebook:main
Choose a base branch
from
GijsWeterings:export-D71979588
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/MountItemDispatcher.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979596
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made MountItemDispatcher.java nullsafe Differential Revision: D71979589
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/MountingManager.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979593
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made MountingManager.java nullsafe Differential Revision: D71979607
…-native/ReactAndroid/src/main/java/com/facebook/react/modules/blob/BlobProvider.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979586
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made BlobProvider.java nullsafe Differential Revision: D71979597
…-native/ReactAndroid/src/main/java/com/facebook/react/modules/blob/FileReaderModule.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979587
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made FileReaderModule.java nullsafe Differential Revision: D71979585
…-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/DialogModule.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979584
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DialogModule.java nullsafe Differential Revision: D71979604
…-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/ReconnectingWebSocket.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979580
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made ReconnectingWebSocket.java nullsafe Differential Revision: D71979606
…-native/ReactAndroid/src/main/java/com/facebook/react/runtime/internal/bolts/Task.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979592
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made Task.java nullsafe Differential Revision: D71979582
…-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleInteropUtils.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979600
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made TurboModuleInteropUtils.java nullsafe Differential Revision: D71979599
…-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleManager.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979595
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made TurboModuleManager.java nullsafe Differential Revision: D71979605
This pull request was exported from Phabricator. Differential Revision: D71979588 |
…-native/ReactAndroid/src/main/java/com/facebook/react/modules/blob/BlobModule.java (facebook#50364) Summary: Pull Request resolved: facebook#50364 Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: [Internal] Differential Revision: D71979588
This pull request was exported from Phabricator. Differential Revision: D71979588 |
a867e5f
to
3b70c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them
Changelog: [Internal]
Differential Revision: D71979588