Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin-react-hooks: Fix international component name compatibility #31456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DavidZidar
Copy link

Summary

This fixes compatiblity with international functional component names such as ÄndraVärde in the ESLint rule RulesOfHooks.

The problem is a Regex that only allows component names to start with the characters A-Z when in reality characters from other languages should be supported too.

Fixes #31446

How did you test this change?

I added a unit test and verified that the rule failed just like it does in my own projects, then I did my modification and verified that the tests pass.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 10:33am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [email protected] only detects english component names
2 participants