[ASTextNode] Fix ASTextNode shadow is not rendering (#2042)

* Passing through shadow in renderer attribute * Fix memory leak setting shadow color
facebookarchive · Aug 15, 2016 · 3e89cf0 · 3e89cf0
1 parent 0e32802
commit 3e89cf0
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/AsyncDisplayKit/ASTextNode.mm b/AsyncDisplayKit/ASTextNode.mm
@@ -44,6 +44,7 @@ @interface ASTextNode () <UIGestureRecognizerDelegate, NSLayoutManagerDelegate>
 @implementation ASTextNode {
   CGSize _shadowOffset;
   CGColorRef _shadowColor;
+  UIColor *_cachedShadowUIColor;
   CGFloat _shadowOpacity;
   CGFloat _shadowRadius;
 
@@ -244,6 +245,10 @@ - (ASTextKitAttributes)_rendererAttributes
     .pointSizeScaleFactors = self.pointSizeScaleFactors,
     .layoutManagerCreationBlock = self.layoutManagerCreationBlock,
     .textStorageCreationBlock = self.textStorageCreationBlock,
+    .shadowOffset = _shadowOffset,
+    .shadowColor = _cachedShadowUIColor,
+    .shadowOpacity = _shadowOpacity,
+    .shadowRadius = _shadowRadius
   };
 }
 
@@ -1055,7 +1060,11 @@ - (void)setShadowColor:(CGColorRef)shadowColor
     if (shadowColor != NULL) {
       CGColorRetain(shadowColor);
     }
+    if (_shadowColor != NULL) {
+      CGColorRelease(_shadowColor);
+    }
     _shadowColor = shadowColor;
+    _cachedShadowUIColor = [UIColor colorWithCGColor:shadowColor];
     [self _invalidateRenderer];
     [self setNeedsDisplay];
   }