Python modeling component #1045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is initial commit for modular design. Most of it is AI generated code from reverse engineering of old code. It need multiple iterations to clean up and finalize the interface design with clear mutable and immutable data class designs. Goal is to finalize interface design before implementation.
…ss logic. (This is rewrite, not porting!)
* modified check_datevar * added more interface methods to mmmdata_validation * Added more check.py methods * addressed comments * added calibration_input_validation * added check_mmmdata_collect * added more methods --------- Co-authored-by: Dhaval Patel <[email protected]>
This reverts commit 0c5008e.
…_interface Revert "Added method signatures from check.py"
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Robyn
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
How Has This Been Tested?
devtools::document(). Should update .Rd files.devtools::check(). Should have no notes, no warning, no errors.