Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixes] update e2e notebooks, improve accuracy for allocator scenarios #1157

Merged
merged 5 commits into from
Nov 21, 2024
Merged

[fixes] update e2e notebooks, improve accuracy for allocator scenarios #1157

merged 5 commits into from
Nov 21, 2024

Conversation

alxlyj
Copy link
Contributor

@alxlyj alxlyj commented Nov 21, 2024 •
edited
Loading

Project Robyn

Summary

We are reworking the allocator codes to improve the numerical and plot accuracies. We also added integration fixes to data mapper and robyn.py.

  • Modeling
    • Test scalings.
  • Allocator
    • Improve accuracy for target efficiency scenario.
  • robyn.py
    • Corrected the function calls to ensure they are invoked with the appropriate parameters and logic.
    • Improved the data handoffs between earlier components and the allocator.
    • Fix missing rssd_zero_penalty boolean.
    • Fix e2e run for all components on notebook.
  • notebooks
    • Fix tutorial1.ipynb
    • Fix tutorial1_src.ipynb

Test Plan

Ran e2e tutorial1.ipynb. Ran tutorial6_allocator.ipynb. Ran tutorial1_src.ipynb.

Generated allocator plot for tutorial1 for max_response scenario:

image

Generated allocator plot for tutorial6_allocator for target efficiency scenario:

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2024
@alxlyj alxlyj changed the base branch from main to robynpy_release November 21, 2024 08:41
@alxlyj alxlyj changed the title Accuracy/e2e part2 fixes [fixes] update e2e notebooks, improve accuracy for allocator scenarios Nov 21, 2024
@alxlyj alxlyj marked this pull request as ready for review November 21, 2024 08:52
@alxlyj alxlyj requested review from sumane81, dhavalpatel624624 and sumalreddy17 and removed request for sumane81 November 21, 2024 08:52
@alxlyj
move old codes as backup
b87928b 
cleanup notebooks and codes

clear all notebook outputs

update notebooks

update allocator notebooks
@alxlyj alxlyj force-pushed the accuracy/e2e_part2_fixes branch from d643d1e to b87928b Compare November 21, 2024 09:53
@alxlyj alxlyj marked this pull request as draft November 21, 2024 09:58
@alxlyj alxlyj marked this pull request as ready for review November 21, 2024 10:09
dhavalpatel624624
dhavalpatel624624 requested changes Nov 21, 2024
View reviewed changes
@dhavalpatel624624
Copy link
Contributor

Do we need the outputs folder with the screenshots?

@alxlyj alxlyj merged commit c6f879b into robynpy_release Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhavalpatel624624 dhavalpatel624624 dhavalpatel624624 approved these changes

@sumane81 sumane81 Awaiting requested review from sumane81

@sumalreddy17 sumalreddy17 Awaiting requested review from sumalreddy17

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxlyj @dhavalpatel624624 @facebook-github-bot