Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for SD alt compilation/demo for T4 SM75 #786

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apivovarov
Copy link
Contributor

Description

Currently compile_alt.py generates bad images on T4 GPU (SM75).
Related issue - #781
Notebook to reproduce the issue with bad images on T4 GPU - AIT_alt_bad_image.ipynb

I found that the issue with bad images can be fixed if we use the following workaround:

  1. compile_clip_alt.py - batch higher dim should be 8+
  2. compile_unet_alt.py - Both lower and upper batch dims should be doubled

I understand that the workaround above uses magic numbers.
But it works...

Testing

Tested on T4 and A100 GPUs .

Compiled with different batch ranges (1-8, 2-4, 1-9) and run demo_alt with different batch sizes (1,2,4,8,9) - all images look ok.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants