Better profile_callable #900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I extended profile_callable to accept a list of events of interest. In the case where this parameter is not specified, profile_callable will collect the timings of all events except those ending in " Sync". This gives us more accurate results; we no longer measure overhead from the syncs. Finally, I converted the softmax benchmark to use profile_callable for both the AIT and PT2 benchmarking. Using the same profiling function ensures we are comparing apples to apples. Differential Revision: D48252668 fbshipit-source-id: cebc4b398e525b2db755192f3c57ab298ac42faf
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48252668 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I extended profile_callable to accept a list of events of interest. In
the case where this parameter is not specified, profile_callable will collect
the timings of all events except those ending in " Sync". This gives us more
accurate results; we no longer measure overhead from the syncs.
Finally, I converted the softmax benchmark to use profile_callable for both the
AIT and PT2 benchmarking. Using the same profiling function ensures we are
comparing apples to apples.
Differential Revision: D48252668